Grimrock

Hmm, very interesting musings.
I'm looking forward to finding out what's going on.

Cheers!

Ooh, yes, I second that request!

Cheers.

I've managed to figure out that all overridden OnComputeAccuracy and OnComputeCritChance functions are called for all weapons, regardless of which skill the weapon uses. I was able to work around this by checking weapon:hasTrait("light_weapon") for the "light_weapons" overrides, ...

Hmm, this might not be solved as I thought it was. I tried cloning the "light_weapons" skill and making it return 100 for both onComputeAccuracy and onComputeCritChance. Now, both a branch (light weapon) and a cudgel (heavy weapon) always hit and always crit. Not sure what's going on here....

I used the cloneObject script as a basis for a cloneSkill script I made.
Details here:
viewtopic.php?p=85615#p85615

OK, I got it working. Here's my "CloneSkill" function which is basically a stripped-down version of JKos's "CloneObject" function. Create a file called, "cloneSkill.lua". Enter this as its contents: local olddefineSkill = defineSkill; local defines = { }; defineSkill = ...

Couldn't you redefine the skills using something similar to JKos's CloneObject script (CloneSkill) and add the hooks for onRecomputeStats, onComputeAccuracy, and onComputeCritChance?

I'm about to try this so I'll let you know how I get on...

In the mean time, I'll just have to use @JKos's cloneObject script and define each weapon in the game with an overridden 'onHitMonster' function. I wanted to do it with script so I didn't have to update my items.lua for every weapon in the game but at least cloneObject allows me to continue...

Thanks for the suggestions but I tried both of them and neither one helped.

I verified that I was working with the right component by adding a call to MeleeAttackComponent:setCameraShake(true) instead of adding my connector and the camera shakes when the item is used.

I'm having trouble getting a callback to work in the editor. I used the following code to add connectors to the weapons in my level: -- Wire up the MeleeAttackComponents on this level. for e in second_timer.map:allEntities() do if e.meleeattack then e.meleeattack:addConnector("onHitMonster"...